Arm backend: Ensure data layout ops dtype validity by AdrianLundell · Pull Request #18540 · pytorch/executorch

AdrianLundell · 2026-03-27T15:11:32Z

Previously dtypes were not checked per tosa spec, leading to data layout ops (TRANSPOSE, RESHAPE...) sometimes being inserted as INT inf PRO-FP, which is invalid.

This patch adds checks and a new pass inserting dtype casts before/after all data layout ops to ensure validity.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Previously dtypes were not checked per tosa spec, leading to data layout ops (TRANSPOSE, RESHAPE...) sometimes being inserted as INT inf PRO-FP, which is invalid. This patch adds checks and a new pass inserting dtype casts before/after all data layout ops to ensure validity. Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: I8e4d88a79e317727d5d0047f8c7aef1f87699bed

pytorch-bot · 2026-03-27T15:11:37Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18540

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 2 Cancelled Jobs, 3 Unrelated Failures

As of commit 736f22e with merge base 490ec5c ():

NEW FAILURES - The following jobs have failed:

pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-models-macos-coreml (efficient_sam) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-models-macos-coreml (ic4) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-models-macos-coreml (vit) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-models-macos-cpu (mv3, xnnpack-quantization-delegation) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / unittest-release / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

CANCELLED JOBS - The following jobs were cancelled. Please retry:

trunk / test-models-macos-coreml (emformer_join) / macos-job (gh)
##[error]The operation was canceled.
trunk / test-models-macos-mps / macos-job (gh)
##[error]The operation was canceled.

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / windows / windows-job (gh) (trunk failure)
##[error]The operation was canceled.
pull / unittest-editable / windows / windows-job (gh) (trunk failure)
##[error]The operation was canceled.
trunk / unittest-release / windows / windows-job (gh) (trunk failure)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: Iff630a5bd12d05119f14be37f819bdb28586a6d2

zingo · 2026-04-15T11:19:57Z

Hi @digant this adds files

Copilot

Pull request overview

This PR tightens Arm-backend TOSA dtype validation for data-layout-related ops and introduces a new lowering pass that inserts dtype casts around those ops to keep graphs valid under the active TOSA profile (notably FP-only / PRO-FP).

Changes:

Add InsertDataLayoutCastsPass to cast inputs/outputs around layout ops when the current TOSA profile doesn’t allow the op’s dtype.
Update several Arm operator lowerings (view/transpose/slice/pad/repeat/permute/cat) to validate allowed dtypes based on the active TOSA spec (integer/float support + extensions).
Add unit tests for the new pass (current coverage focuses on view_copy and cat).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
backends/arm/test/passes/test_insert_data_layout_casts_pass.py	Adds tests asserting cast insertion behavior for `view_copy` and `cat` under FP profile.
backends/arm/operators/op_view.py	Makes allowed dtypes depend on the active TOSA spec instead of a fixed list.
backends/arm/operators/op_tosa_transpose.py	Same: spec-driven dtype validation for transpose lowering.
backends/arm/operators/op_tosa_slice.py	Adds missing dtype/input-count validation for SLICE lowering (spec-driven).
backends/arm/operators/op_tosa_pad.py	Adds missing dtype/input-count validation for PAD lowering (spec-driven).
backends/arm/operators/op_repeat.py	Switches to spec-driven dtype validation for repeat/tile lowering.
backends/arm/operators/op_permute.py	Switches to spec-driven dtype validation for permute/transpose lowering.
backends/arm/operators/op_cat.py	Refines supported dtype logic to respect integer/float profile + int16/bf16 extensions.
backends/arm/_passes/insert_data_layout_casts_pass.py	New pass that inserts `_to_dim_order_copy` casts around targeted layout ops based on TOSA profile support.
backends/arm/_passes/arm_pass_manager.py	Wires `InsertDataLayoutCastsPass` into the default TOSA pipeline.
backends/arm/_passes/init.py	Exports `InsertDataLayoutCastsPass`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-20T10:41:43Z

+def test_insert_data_layout_casts_no_target_view_fp_profile_skips_supported_dtype() -> (
+    None
+):


The return type annotation here is split across multiple lines with parentheses, which is non-idiomatic and makes the signature harder to scan. Consider formatting it as a standard one-line -> None (or reflowing with a formatter) to match the style used by the other tests in this file.

Suggested change

def test_insert_data_layout_casts_no_target_view_fp_profile_skips_supported_dtype() -> (

None

):

def test_insert_data_layout_casts_no_target_view_fp_profile_skips_supported_dtype() -> None:

Copilot · 2026-04-20T10:41:43Z

+        exir_ops.backend.tosa.TRANSPOSE.default,
+        exir_ops.edge.aten.constant_pad_nd.default,
+        exir_ops.edge.aten.view_copy.default,
+        exir_ops.edge.aten.repeat.default,
+        exir_ops.edge.aten.permute_copy.default,


InsertDataLayoutCastsPass is intended to cover PAD and SLICE (per docstring/PR description), but targeted_ops currently only includes the edge forms (aten.constant_pad_nd, aten.slice_copy) while the main Arm TOSA pipeline rewrites these to exir_ops.backend.tosa.PAD.default and exir_ops.backend.tosa.SLICE.default (via RewritePadPass/RewriteSlicePass) before this pass runs. As a result, casts will not be inserted around the PAD/SLICE nodes that actually reach serialization in the real pipeline. Include the backend TOSA PAD/SLICE targets in targeted_ops (and ideally add a unit test that runs RewritePadPass/RewriteSlicePass before this pass to prevent regressions).

Suggested change

exir_ops.backend.tosa.TRANSPOSE.default,

exir_ops.edge.aten.constant_pad_nd.default,

exir_ops.edge.aten.view_copy.default,

exir_ops.edge.aten.repeat.default,

exir_ops.edge.aten.permute_copy.default,

exir_ops.backend.tosa.TRANSPOSE.default,

exir_ops.backend.tosa.PAD.default,

exir_ops.edge.aten.constant_pad_nd.default,

exir_ops.edge.aten.view_copy.default,

exir_ops.edge.aten.repeat.default,

exir_ops.edge.aten.permute_copy.default,

exir_ops.backend.tosa.SLICE.default,

AdrianLundell · 2026-04-20T10:42:26Z

No buck2 changes should be needed with this change:

The new pass file is auto-included by glob(["*.py"]) in backends/arm/_passes/TARGETS.
The new test file is auto-included by native.glob(["passes/test_*.py"]) in backends/arm/test/targets.bzl.
Operator changes are in existing files already covered by glob(["op_.py", "ops_.py"]) in backends/arm/operators/TARGETS.

zingo

OK to merge

AdrianLundell · 2026-04-20T14:35:35Z

Fails not related

AdrianLundell requested a review from digantdesai as a code owner March 27, 2026 15:11

AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Mar 27, 2026

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 27, 2026

zingo approved these changes Mar 28, 2026

View reviewed changes

AdrianLundell and others added 3 commits April 7, 2026 10:12

Merge branch 'main' into change-1227017

dfbac75

Merge branch 'main' into change-1227017

b48d5d2

Arm backend: Data layout cast bugfixes

82af6a5

Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: Iff630a5bd12d05119f14be37f819bdb28586a6d2

Merge branch 'main' into change-1227017

736f22e

Copilot AI review requested due to automatic review settings April 20, 2026 10:34

Copilot started reviewing on behalf of AdrianLundell April 20, 2026 10:34 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

zingo approved these changes Apr 20, 2026

View reviewed changes

AdrianLundell merged commit 063f9c9 into pytorch:main Apr 20, 2026
413 of 426 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arm backend: Ensure data layout ops dtype validity#18540

Arm backend: Ensure data layout ops dtype validity#18540
AdrianLundell merged 5 commits intopytorch:mainfrom
AdrianLundell:change-1227017

AdrianLundell commented Mar 27, 2026 •

edited by pytorch-bot Bot

Loading

Uh oh!

pytorch-bot Bot commented Mar 27, 2026 •

edited

Loading

Uh oh!

zingo commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 20, 2026

Uh oh!

Copilot AI Apr 20, 2026

Uh oh!

AdrianLundell commented Apr 20, 2026

Uh oh!

zingo left a comment •

edited

Loading

Uh oh!

AdrianLundell commented Apr 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

AdrianLundell commented Mar 27, 2026 • edited by pytorch-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18540

❌ 6 New Failures, 2 Cancelled Jobs, 3 Unrelated Failures

Uh oh!

zingo commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

AdrianLundell commented Apr 20, 2026

Uh oh!

zingo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdrianLundell commented Apr 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AdrianLundell commented Mar 27, 2026 •

edited by pytorch-bot Bot

Loading

pytorch-bot Bot commented Mar 27, 2026 •

edited

Loading

zingo left a comment •

edited

Loading